Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LWG-3610: iota_view::size sometimes rejects integer-class types #2542

Merged
merged 5 commits into from
Feb 12, 2022
Merged

LWG-3610: iota_view::size sometimes rejects integer-class types #2542

merged 5 commits into from
Feb 12, 2022

Conversation

frederick-vs-ja
Copy link
Contributor

Implements the proposed resolution of LWG-3610.

Only tests the cases where an integer-class type is used as the bound type, because MSVC STL currently has no integer-class type satisfying weakly_incrementable.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner February 8, 2022 06:34
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Feb 8, 2022
@CaseyCarter CaseyCarter mentioned this pull request Feb 8, 2022
Closed
20 tasks
@frederick-vs-ja @CaseyCarter
Move static_asserts out of main in the compile-only test
13a53ad 
Co-authored-by: Casey Carter <cartec69@gmail.com>
@StephanTLavavej
Copy link
Member

Thanks! I pushed a one-line fix. FYI @CaseyCarter.

@StephanTLavavej StephanTLavavej self-assigned this Feb 11, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3f5b8ff into microsoft:main Feb 12, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution fixing iota_view! 🔢 🚀 ✅

@frederick-vs-ja frederick-vs-ja deleted the lwg-3610 branch February 13, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter